-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ghc support for 8.6.4, 8.10.2, 8.10.3, 8.10.4 #2197
Conversation
jneira
commented
Sep 16, 2021
•
edited
Loading
edited
- Following the incoming ghc deprecation policy ghc support deprecation schedule #2168
- Include the bump of ghc-lib* versions to 8.10.7 and the use of 8.10.7 in tests and benchmarks
- Update hackage index to 2021-09-16T07:00:23Z
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Should we change the default |
good catch! i forgot to update it, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! However, this PR cannot be automatically merged, as
- This PR changes CI config
- This PR adds/removes some CI entries, so branch protection rule should be updated
/rerun-workflow Testing |
|
Is there any specific reason why 8.8.3 is still here? Will it be removed at a later point or is it meant to stay for longer or was it simply forgotten? |
hi, we keep it following the deprecation policy discussed in #2168, it says we will keep the last 2 minor versions for relatively recent ghc versions |
Ah, I see! I missed that part! Thanks! |
I was looking at the table which said:
which is what confused me. (ghc-8.8.3 is under the removed section) |
oh, yeah, that was the initial proposal but it has changed due the discussion, we have to write down the definitive one with a new table |
* Remove outdated setup troubleshooting * Remove ghc-8.6.4 support * Remove ghc-8.10.2 support * Remove ghc-8.10.3 support * Remove ghc-8.10.4 support * Complete list of tested ghcs * Update stack resolvers * Update hackage index * Set 8.10.7 as default stack.yaml * Use extra 1.7.9