Remove ghc-api source snapshot

[pepeiborra]

We can replace the source snapshot with Cabal conditions to unblock Hackage uploads until #2128 lands

The source snapshot cannot be removed for ghc 8.10.7 nor 9.0.1. In the former, an allow-newer suffices, but in the later we need unreleased changes that can only be obtained via the source snapshot.

/cc @fendor

[jneira]

this looks like can be backported to 1.3.0-hackage
I was thinking in give up trying to release 1.3.0 and go directly for 1.4.0 starting right now, thoughts?

[pepeiborra]

this looks like can be backported to 1.3.0-hackage
I was thinking in give up trying to release 1.3.0 and go directly for 1.4.0 starting right now, thoughts?

When do you plan to release 1.4.0? We haven't had a Hackage release in a long time, and this has been blocking adoption for several user groups.

[jneira]

I wanted to start it asap, to have 8.10.7 support amongs other things

[jneira]

btw ghc-api-compat does not have support for ghc-8.10.7 without allow newer 😕

[pepeiborra]

This is ready to go! GHC up to 8.10.6 is the best I could do until Sylvain uploads new versions to Hackage or until @fendor lands #2128

[jneira]

many thanks for the plumbing work, maybe the conditionals will be removed soon (if fendor's pr lands soon)

[pepeiborra]

Sylvain has uploaded new versions to Hackage, so I will add more conditionals and resubmit

[jneira]

@pepeiborra it seems we could merge soon #2156 so we could:

• close this and go for it directly, i think it could be hard to backport, so we would go for 1.4.0 and skip 1.3.0 for hackage
• merge this, backport to 1.3.0 and make the hackage release, and rebase and merge Remove ghc-api source snapshot #2156 just after that
• backport this pr to 1.3.0-hackage without merge it in master

thoughts?

//cc @fendor

[pepeiborra]

Merge, backport and upload to Hackage is my preference, assuming it's not holding #2128 back

[jneira]

@Mergifyio backport 1.3.0-hackage

[mergify]

Command backport 1.3.0-hackage: failure

No backport have been created

• Backport to branch 1.3.0-hackage failed: Git reported the following error:

Auto-merging stack-9.0.1.yaml
CONFLICT (content): Merge conflict in stack-9.0.1.yaml
Auto-merging stack-8.8.4.yaml
Auto-merging stack-8.8.3.yaml
Auto-merging stack-8.6.5.yaml
Auto-merging stack-8.6.4.yaml
CONFLICT (modify/delete): stack-8.10.7.yaml deleted in HEAD and modified in a23b66c3 (Remove ghc-api source snapshot (#2156)). Version a23b66c3 (Remove ghc-api source snapshot (#2156)) of stack-8.10.7.yaml left in tree.
Auto-merging stack-8.10.5.yaml
Auto-merging stack-8.10.4.yaml
Auto-merging stack-8.10.3.yaml
Auto-merging stack-8.10.2.yaml
Auto-merging plugins/hls-ormolu-plugin/hls-ormolu-plugin.cabal
Auto-merging plugins/hls-call-hierarchy-plugin/hls-call-hierarchy-plugin.cabal
Auto-merging hls-plugin-api/hls-plugin-api.cabal
Auto-merging haskell-language-server.cabal
Auto-merging ghcide/ghcide.cabal
Auto-merging cabal.project
Auto-merging cabal-ghc901.project
CONFLICT (content): Merge conflict in cabal-ghc901.project
error: could not apply a23b66c3... Remove ghc-api source snapshot (#2156)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

[pepeiborra]

Backported manually