-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial sphinx doc site for RTD #2083
Conversation
You are an admin now |
93c4063
to
52e11cb
Compare
ed0db23
to
6a4978a
Compare
Okay, I set up the build and it builds PRs too, so you can see a link to a preview from the PR status. |
1404a58
to
12ad9d4
Compare
I should add some instructions about how to build the doc site into the docs @jneira I'm afraid I don't know what to do about Windows. I think you should "just" need to install python and the required packages however you do that... There is this little requirements.txt I had to make for RTD, perhaps you can use that and pip or something? |
yeah don't worry, with a little bit of luck it only will need some python setup |
12ad9d4
to
07bcee0
Compare
Okay, I added a section about building the docs. I think this is good to go if we're happy with how it looks and we want to go with RTD. |
I've added the make.bat auto generated by sphinx-quickstart, but it is failing at a first blind attempt:
|
|
I think you just need to do |
I'll add that to the doc. |
8a4efa1
to
3a473c7
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs looks fantastic, many thanks to spend time on this, documentation usually has not the attention it deserves so i value specially pr's like this, congrats!
Mmm not sure about this, i would like to see some brief content in the README, no a copy from the full docs but a resume or something for those who want to take a quick look |
The nix build (not required though) is failing with
|
Yeah, not sure what to do about this. It would be nice not to repeat ourselves. Maybe we can write a section that we can include into both? There's not much introductory prose at all even in the current docs, just a sentence. Maybe I can link to a few specific interesting sections like "features", "building the code", "contributing guidelines".
It's broken on master in the same way 🤷 |
Follow-up to haskell#2083. Now that all this documentation is hosted on an external site, there really ought to be a link back here.
Follow-up to #2083. Now that all this documentation is hosted on an external site, there really ought to be a link back here.
This sets up an initial sphinx doc site that we can use with RTD. I would need some help from a repository admin to get it building on RTD itself, but you can build the site locally:
I moved all the content from the README to the docs, with the intention being to eventually just link to the RTD site from the README. Otherwise I haven't touched the content, apart from fixing a few links and header depths. There's a lot more organization etc. that we could do, but probably better to do that after we have an initial version.
I set up sphinx to use markdown, since I know people like that. The exception is the index pages, which I think need to be in RST for the toctree definitions. I do like RST, especially for better cross-reference, but the markdown version seems to work fairly well.
Fixes #2033.
(cc @berberman since I had to fiddle with the Nix stuff a bit)