Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use operational master commit to fix build for ghc-9.0.1 #2017

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Use operational master commit to fix build for ghc-9.0.1 #2017

merged 3 commits into from
Jul 14, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Jul 13, 2021

@jneira jneira changed the title Use operational master Use operational master commit to fix build for stack and ghc-9.0.1 Jul 13, 2021
@jneira jneira requested a review from berberman July 13, 2021 21:19
isovector
isovector approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@isovector isovector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Ailrun
Ailrun reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. BTW, cabal-ghc901.project should also be fixed to make CI work.

@jneira
Copy link
Member Author

jneira commented Jul 13, 2021

Thank you. BTW, cabal-ghc901.project should also be fixed to make CI work.

thanks! i was just about to commit the change

@jneira jneira added the merge me Label to trigger pull request merge label Jul 13, 2021
@jneira jneira changed the title Use operational master commit to fix build for stack and ghc-9.0.1 Use operational master commit to fix build for ghc-9.0.1 Jul 13, 2021
@isovector
Copy link
Collaborator

This fixes it, but CI is flaky af. I've restarted CI and maybe one day we'll be able to get code merged again :)

berberman
berberman approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, I also updated the nix config for ghc 9.0.1 here

@mergify mergify bot merged commit 6e47614 into haskell:master Jul 14, 2021
@jneira
Copy link
Member Author

jneira commented Jul 14, 2021

This fixes it, but CI is flaky af. I've restarted CI and maybe one day we'll be able to get code merged again :)

yeah, I am gonna disable tests for Windows and 9.0.1 😟

@jneira jneira deleted the fix-ci-ghc-9 branch July 14, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun left review comments

@berberman berberman berberman approved these changes

@isovector isovector isovector approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI for 9.0.1 is broken due to missing upstream commit
4 participants
@jneira @isovector @Ailrun @berberman