Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid holding onto the hie bytestring when indexing #1947

Merged
merged 2 commits into from
Jun 20, 2021
Merged

Conversation

pepeiborra
Copy link
Collaborator

This can save significant amounts of memory on large repos, as shown by the heap profiles generated using the edit experiment on a module with >10K transitive deps.

BEFORE
Screenshot 2021-06-20 at 11 41 05

AFTER
Screenshot 2021-06-20 at 11 41 57

@pepeiborra pepeiborra requested a review from wz1000 June 20, 2021 10:42
@pepeiborra pepeiborra force-pushed the exclude-hie_hs_src branch from 445a000 to 0fcb63d Compare June 20, 2021 11:13
@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Jun 20, 2021
@mergify mergify bot merged commit 6ffc6c5 into master Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants