-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.2.0 June release #1912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should bump the versions of ghcide, hls-graph and his-plugin-api as well in preparation for the Hackage upload? |
@pepeiborra Oh, right. I will bump those too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think we should bump hls-brittany-plugin
to 1.0.0.2
plugins/hls-refine-imports-plugin/hls-refine-imports-plugin.cabal
Outdated
Show resolved
Hide resolved
@@ -48,7 +48,7 @@ library | |||
, extra | |||
, filepath | |||
, ghc-exactprint >=0.6.3.4 | |||
, ghcide >=1.2 && <1.4 | |||
, ghcide ^>=1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes because hlint plugin probably won't work with ghcide <= 1.3 after #1862
I don't see the |
@hasufell It's not yet built. It will be built after all other version-specific |
the tar job seems to be failing: https://github.com/haskell/haskell-language-server/runs/2813407586?check_suite_focus=true |
Yes, I'm resolving the issue. |
Also... since ghcup now supports windows too, we'd need a |
sure, will do this night gmt |
As usual i have to generate manually the version for 8.8.4 (#276), the only one we support for windows and it will take some time in my poor laptop |
Should we add the ghc-9.0 build as well to the release, so users doesn't have to build manually from source to get the basic ghc-9.0 support? Or is it to late now? |
It is a good idea, if the executable can be used without tweaking too much configuration. A note should be added in the release, with a warning for the limited support and linking to the list of working components. |
No, there shouldn't be much configuration tweaking needed. Adding the flag I don't think disabling automatic download should be needed, as long as it is clear to the user that it is experimental, since partial support is better than no support at all. |
Resolves partially #1890