Use cabal-install if nix is failing in CI #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
reviewed
May 23, 2021
pepeiborra
reviewed
May 23, 2021
|
@jneira Branch protection rules need updates correspondingly We should remove:
And add:
|
you could do it no yourself right now 🙂 (but i did the change anyways to merge asap) |
berberman
commented
May 24, 2021
Comment on lines
+57
to
+61
| # Build and then push HLS binaries with developmet shell to cachix | ||
| # This job runs when PRs are merged to master, and should be excluded from branch protections | ||
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| if: ${{ github.repository_owner == 'haskell' && github.ref == 'ref/heads/master' }} |
There was a problem hiding this comment.
It didn't run as expected :(
https://github.com/haskell/haskell-language-server/actions/runs/870310690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided to maintain the nix packaging (building HLS binaries in nix) in #1827. Ideally, we are always have HLS binaries prepared without
cabal-install. However, PRs that update project dependencies like #1858 may be blocked by nix ci, since nixpkgs does not have the new dependency yet, and even if it has, a bump of nixpkgs is required. It's unreasonable to require every contributor to handle nix things, so this PR add a fallback in CI, which usescabal-installto build HLS in case some required packages are missing in nixpkgs.Also adds
default.nix, so that the legacynix-buildcan work.