Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upper bound to hlint #1795

Merged
merged 2 commits into from
May 5, 2021
Merged

Add upper bound to hlint #1795

merged 2 commits into from
May 5, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented May 4, 2021

  • Without the upper bound, cabal picks hlint-3.* which brings ghc-lib-9.* causing compile errors (what this has not been catched by ci before?)
  • This has to be backported to hackage-1.1.0 to make progress towards Hackage release of 1.1.0 #1774

@jneira jneira requested a review from berberman May 4, 2021 20:41
@jneira
Copy link
Member Author

jneira commented May 4, 2021

@Mergifyio backport 1.1.0-hackage

@mergify
Copy link
Contributor

mergify bot commented May 4, 2021

Command backport 1.1.0-hackage: pending

Waiting for the pull request to get merged

@Ailrun Ailrun added the merge me Label to trigger pull request merge label May 4, 2021
@mergify mergify bot merged commit ee7b5a9 into haskell:master May 5, 2021
mergify bot pushed a commit that referenced this pull request May 5, 2021
@jneira
Add upper bound to hlint (#1795)
6576cc9 
Co-authored-by: Junyoung/Clare Jang <[email protected]>
(cherry picked from commit ee7b5a9)
@mergify mergify bot mentioned this pull request May 5, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Command backport 1.1.0-hackage: success

Backports have been created

jneira added a commit that referenced this pull request May 5, 2021
@mergify @jneira
Add upper bound to hlint (#1795) (#1797)
2354e2c 
Co-authored-by: Junyoung/Clare Jang <[email protected]>
(cherry picked from commit ee7b5a9)

Co-authored-by: Javier Neira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@berberman berberman Awaiting requested review from berberman

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneira @Ailrun