Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heralds to Wingman's use of runAction #1740

Merged
merged 2 commits into from
Apr 17, 2021
Merged

Add heralds to Wingman's use of runAction #1740

merged 2 commits into from
Apr 17, 2021

Conversation

isovector
Copy link
Collaborator

This PR adds heralds to Wingman's use of runAction. As a result, the debug logs now look like this:

2021-04-16 12:44:22.935457349 [ThreadId 590] INFO hls:	finish: Wingman.getIdeDynflags.GetModSummaryWithoutTimestamps (took 0.00s)
2021-04-16 12:44:22.935495533 [ThreadId 592] INFO hls:	finish: codeLens.GetGlobalBindingTypeSigs (took 0.00s)
2021-04-16 12:44:22.935756369 [ThreadId 594] INFO hls:	finish: Wingman.codeLensProvider.GetAnnotatedParsedSource (took 0.00s)
2021-04-16 12:44:22.936314236 [ThreadId 598] INFO hls:	finish: ModuleName.GetParsedModule (took 0.00s)
2021-04-16 12:44:22.936271495 [ThreadId 596] INFO hls:	finish: Wingman.codeLensProvider.GetBindings (took 0.00s)
2021-04-16 12:44:22.93657869 [ThreadId 600] INFO hls:	finish: Wingman.emptyCaseScrutinees.TypeCheck (took 0.00s)
2021-04-16 12:44:22.937092368 [ThreadId 602] INFO hls:	finish: Wingman.emptyCaseScrutinees.GhcSessionDeps (took 0.00s)

which is significantly more informative than the old

2021-04-16 12:44:22.935457349 [ThreadId 590] INFO hls:	finish: tactic (took 0.00s)
2021-04-16 12:44:22.935495533 [ThreadId 592] INFO hls:	finish: codeLens.GetGlobalBindingTypeSigs (took 0.00s)
2021-04-16 12:44:22.935756369 [ThreadId 594] INFO hls:	finish: tactic (took 0.00s)
2021-04-16 12:44:22.936314236 [ThreadId 598] INFO hls:	finish: ModuleName.GetParsedModule (took 0.00s)
2021-04-16 12:44:22.936271495 [ThreadId 596] INFO hls:	finish: tactic (took 0.00s)
2021-04-16 12:44:22.93657869 [ThreadId 600] INFO hls:	finish: tactic (took 0.00s)
2021-04-16 12:44:22.937092368 [ThreadId 602] INFO hls:	finish: tactic (took 0.00s)

@isovector isovector added the merge me Label to trigger pull request merge label Apr 17, 2021
@mergify mergify bot merged commit 7dcd1c3 into haskell:master Apr 17, 2021
@isovector isovector deleted the annotate-use branch May 21, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isovector @jneira