Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fill hole lost expected backquote #1694

Closed
wants to merge 1 commit into from

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Apr 8, 2021

Fix #1690.
I match the backquote as the solution, but I am not sure that is an appropriate way to update the range at this function.

Copy link
Collaborator

@OliverMadine OliverMadine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

This has an issue when the hole needs to be filled with an infix operator since in this case, it should not have any backquotes. For example, the action "replace _ with (+)" will fill the hole with `(+)` rather than +.

@July541
Copy link
Collaborator Author

July541 commented Apr 9, 2021

Hello,

This has an issue when the hole needs to be filled with an infix operator since in this case, it should not have any backquotes. For example, the action "replace _ with (+)" will fill the hole with (+) rather than +.

Thanks,
I made a silly mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infix backticked holes get their backticks deleted once filled
2 participants