Remove ignored paths #1623
Merged
Remove ignored paths #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ailrun
reviewed
Mar 26, 2021
.github/workflows/bench.yml
Outdated
| @@ -86,6 +90,8 @@ jobs: | |||
| path: ~/.cabal/cabal.tar.gz | |||
|
|
|||
| bench-example: | |||
| needs: pre_job | |||
| if: ${{ needs.pre_job.outputs.should_skip != 'true' }} | |||
| needs: [bench-init] | |||
There was a problem hiding this comment.
Is it possible to have two needs keys? I thought yaml is just more elaborated json...
There was a problem hiding this comment.
In the case that bench-init is skipped, is bench-example still reachable if we don't add this?
There was a problem hiding this comment.
It will skip its computation but from the GitHub's point of view I think the jot itself is not skipped, and will execute following jobs...
There was a problem hiding this comment.
Even if the action lets you duplicate keys it is better to have only one, will change
EDIT: And it is not valid:
.github/workflows/bench.yml#L95
The workflow is not valid. .github/workflows/bench.yml (Line: 95, Col: 5): 'needs' is already defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paths-ignoredoesnt work with required checks branch protection rules: https://github.community/t/path-filtering-on-required-pull-request-checks/18402/3skip-duplicate-actionswhich was being already used can be used to get the same functionality: https://github.com/marketplace/actions/skip-duplicate-actions#option-1-skip-entire-jobs