Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests of plugins #1612

Merged
merged 10 commits into from
Mar 25, 2021
Merged

Migrate tests of plugins #1612

merged 10 commits into from
Mar 25, 2021

Conversation

berberman
Copy link
Collaborator

This PR moves the tests of

  • Class plugin
  • Splice plugin
  • Haddock comments plugin

from HLS's func-test to their packages.

@berberman
Copy link
Collaborator Author

berberman commented Mar 24, 2021

It seems that circle ci failed due to the lack of memory...

--  While building package hls-eval-plugin-1.0.0.0 (scroll up to its section to see the error) using:
      /root/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_3.2.1.0_ghc-8.10.4 --builddir=.stack-work/dist/x86_64-linux/Cabal-3.2.1.0 build lib:hls-eval-plugin exe:test-server test:tests --ghc-options " -fdiagnostics-color=always"
    Process exited with code: ExitFailure (-9) (THIS MAY INDICATE OUT OF MEMORY)

Exited with code exit status 1
CircleCI received exit code 1

Perhaps we could decrease the parallelism (the number of packages we build at the same time), such as running stack build -j1 in the job Build Testsuite without running it

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks again, it is nice to see how plugins are being emancipated 🙂

@berberman berberman merged commit df67bee into haskell:master Mar 25, 2021
@berberman berberman deleted the plugin-tests branch March 25, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants