Use CiInterface/SkInterface for typeclass symbols #1592
Conversation
|
Just a question: does this affect anything other than icons in auto-completion popup? |
|
@Ailrun Yes, the document symbol icons (e.g. in the outline and breadcrumbs of the editor) are also updated. |
|
Oh, right. So it's all about icons, right? |
|
Yup. |
| @@ -69,7 +69,7 @@ documentSymbolForDecl (L (RealSrcSpan l) (TyClD _ FamDecl { tcdFam = FamilyDecl | |||
| t -> " " <> t | |||
| ) | |||
| , _detail = Just $ pprText fdInfo | |||
| , _kind = SkClass | |||
| , _kind = SkInterface | |||
There was a problem hiding this comment.
This one is actually for type families, right? I think the PR description is a bit misleading...
There was a problem hiding this comment.
Whoops, you're right, thanks!
There was a problem hiding this comment.
Is there any reason to leave them as SkClass?
There was a problem hiding this comment.
Wasn't entirely sure about type families, but in any case we should do it consistently. Thinking about it, SkInterface seems more appropriate than SkClass for type families too, since type families are somewhat analogous to type classes, but over data instead of functions.
What do you think?
There was a problem hiding this comment.
🌶️ suggestion: SkFunction. Isn't a type family really a type-level function? :D
Fixes #1581
This branch replaces the
CiClass/SkClassitem kinds for completions and document symbols withCiInterface/SkInterface(see the linked issue for the motivation behind this change).Additionally, the symbol icons for type families which were previously
SkClasshave been replaced withSkFunction.