Give a canonical ordering for destructing terms in Wingman #1586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, Wingman tries to destruct terms in any order. For example, when trying to synthesize
zip
, it will try the following solutions:and
These two solutions are equal modulo the order in which we did a pattern match. But it's stupid to explore both paths, since they cannot produce different answers.
Instead, this PR introduces a canonical ordering on the destructing on terms, using the natural ordering of introduction in the hypothesis. In particular, Wingman will not try to destruct anything that was introduced before something that has already been destructed.
This change has a remarkable
O(n!)
asymptotic increase at each hole 🤩 The search is still remains stupid, but at least it's no longer factorially stupid.