-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remove constraint #1578
Merged
Merged
Fix remove constraint #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
force-pushed
the
fix-remove-constraint
branch
from
March 15, 2021 18:43
e0c69e4
to
f88a5f8
Compare
kderme
force-pushed
the
fix-remove-constraint
branch
from
March 15, 2021 19:11
f88a5f8
to
58e95fc
Compare
Test failures. Not sure where this space comes from 🤔
|
berberman
reviewed
Mar 16, 2021
berberman
previously approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and tests are great! Thank you!
jneira
added
the
status: needs info
Not actionable, because there's missing information
label
Apr 13, 2021
jneira
removed
the
status: needs info
Not actionable, because there's missing information
label
May 1, 2021
berberman
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr refactors the code actions which remove redundant constraints from function signatures.
The new approach traverses the ast to find the related
Sig
and uses theExactPrint
functionality to create a new signature. The old approach did some text manipulation of the module, which was not very reliable. This caused a number of issues which are now fixed:resulted in
forall
were not fixed at allcreated no visible change
Tests are failing (hence the draft) because
ExactPrint
creates an unnecessary space. I'm still trying to understand why and exactly howTransformT
worksI think the pr also helps fixing #1300, but doesn't really fix it.