-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve how wingman uses evidence #1549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2021
isovector
changed the title
Pull evidence from HsWrappers and ConPatOut sources
Improve how wingman uses evidence
Mar 10, 2021
isovector
commented
Mar 10, 2021
plugins/hls-tactics-plugin/test/golden/AutoThetaGADTDestruct.hs.expected
Show resolved
Hide resolved
jneira
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1517 made Wingman's evidence search much more robust, but I found some more places that GHC can stick dictionaries. This PR adds a few more sources of evidence, namely from GADT constructors and calls to rank-n functions.
That means now we can solve holes like this:
Additionally, Wingman can now use evidence that is synthesized when pattern matching on a GADT.
While testing this feature, I realized that Wingman wasn't rewarding generated solutions for using user-bound variables, so that's also included here.
Fixes #1285
Fixes #1550
Fixes #1551