Be much more intelligent about splitting matches #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
isovector
commented
Mar 10, 2021
isovector
commented
Mar 10, 2021
plugins/hls-tactics-plugin/test/golden/SplitPattern.hs.expected
Outdated
Show resolved
Hide resolved
konn
reviewed
Mar 10, 2021
konn
reviewed
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wingman used to implement case split by guessing where in the AST the match group was, and then annotating from there. But this had lots of problems --- it wouldn't work in
wherebindings, orclassdefaults. And I'd hand-coded support forinstancemethods, but due to a bug it would reformat the entire declaration.This PR adds some new
sybtraversals that let us target very specific parts of the AST. For example, it's now possible to target "the smallest MatchGroup that contains a given source span," and then run a list-bind over itsMatches. The machinery is reusable for other purposes, and makes theGraftsystem more composable.Fixes #1542
Fixes #1541
Fixes #1516