Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-determinism in boot-def test #1483

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix non-determinism in boot-def test #1483

merged 1 commit into from
Mar 3, 2021

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Mar 3, 2021

Earlier boot-def failed in ~1/20 runs on my machine.

After this fix, I ran the test 200 times and observed 0 failures.

@wz1000
Copy link
Collaborator Author

wz1000 commented Mar 3, 2021

All ghcide tests seem to have passed in one attempt across all platforms on CI.

@wz1000 wz1000 requested a review from pepeiborra March 3, 2021 12:55
@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Mar 3, 2021
@mergify mergify bot merged commit cfbc9c5 into master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants