Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hls-tactics-plugin tests in CI #1474

Merged
merged 6 commits into from
Mar 2, 2021
Merged

Enable hls-tactics-plugin tests in CI #1474

merged 6 commits into from
Mar 2, 2021

Conversation

isovector
Copy link
Collaborator

I noticed in #1472 that my tests were red but CI was fine. Turns out the tests aren't running in CI!

@isovector isovector added the CI Continuous integration label Mar 1, 2021
jneira
jneira reviewed Mar 1, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the mergify config file (and the CI check in github itself)

@isovector
Copy link
Collaborator Author

@jneira do you know what changes need to be made? I'm out of my depth on this stuff.

@Ailrun
Copy link
Member

Ailrun commented Mar 1, 2021

Actually in this case you don't need to update mergify.yml, as your change is a part of "test" workflow.

Ailrun
Ailrun approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@isovector
Copy link
Collaborator Author

Yay! tests are now failing in CI. Should be fixed when #1472 lands.

@isovector isovector added the merge me Label to trigger pull request merge label Mar 1, 2021
@Ailrun Ailrun merged commit 00e3577 into haskell:master Mar 2, 2021
@isovector isovector deleted the enable-wingman-tests branch April 5, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira left review comments

@Ailrun Ailrun Ailrun approved these changes

Assignees
No one assigned
Labels
CI Continuous integration merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isovector @Ailrun @jneira