Generate a more robust top-level binding Provenance #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isovector
changed the title
isovector
changed the title
jneira
approved these changes
Mar 4, 2021
…-server into fix-top-binds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since #1379 landed, tactics has encouraged a workflow where the users refine the binds directly in the
HsMatchof theFunBind(the arguments to the left of the equals.) But the code that turned those arguments into aHypothesiswas written back before we had a good notion of bindingProvenance, and so it just sorta worked with variable binds and maybe something approximate to the right thing.This PR generates a robust provenance from the top-level binds, capable of handling at-patterns, constructor matches and record destructuring.
One particularly evidence side effect of this new system is that non-variable top-level binds no longer prevent
Destruct all function argumentsfrom being suggested.