-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pre commit hook for code formatting #1384
Conversation
many thanks, agree with the exposed plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jneira As far as there are different default extensions per directory, no |
wow 1100 lines of config are hard to digest for me too |
@jneira Yeah sure, all those comments are of the default config generator, and we have a reference link, I think it's good to go. |
6a492ad
to
f871fff
Compare
@jneira How about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it looks much better now, many thanks!!
Resolves partially #693.
I will format code base after this PR. I think it's quite hard to find a time slot when there is no "big" PR, so it's maybe better to send the setting first, and format after (in time slots between big PRs), so that other big PRs can use the setting to format them by their own.