Clean dependency data structures and speed up GetDependencies #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only parallelizes the branching step, to truly parallelize the search it would be nice to use monad-par. Unfortunately I cannot find a monad transformer version of it that can be laid on top of the Action monad
|
The benchmarks don't show any measurable impact to performance, as expected given the relatively small size of our examples |
|
Reproducing the comment in one of the commits for ease of review:
|
wz1000
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking to improve the performance of
GetDependencies(see #1359) I found some redundancies in the dependency tracking code - we don't use package dependencies anywhere.I expect the performance improvements to be very modest, if at all noticeable in the current benchmark examples, but I haven't measured myself. Will check CI when it's done.