Simplify extracts after running tactics #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isovector
commented
Feb 12, 2021
isovector
changed the title
jneira
approved these changes
Feb 12, 2021
|
@jneira thanks for the bits! I have a preference for tagging you due to how promptly you respond to PRs, but please let me know if it's over too often! |
|
@TOTBWF mind doing a review of this as well? |
|
no problem, but i am afraid that i cant do reviews in deep 😟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small simplification step after running tactics, which attempts to perform some common Haskell idioms. It will eta reduce expressions, so no more stupid implementations like
fmap (\a -> f a) x. It also composes functions, so\x -> f (g x)becomesf . ginstead.The goal is not to be perfect and replace hlint, merely just to get the easy cases.
I'd like to put some real tests on these simplifier functions, but it's not clear to me how to do so. If anyone has any ideas, please let me know!
@TOTBWF please review.