Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication of code actions for adding NamedFieldPuns #1334

Merged
merged 4 commits into from
Feb 9, 2021

Conversation

berberman
Copy link
Collaborator

I took a quick look and noted that duplicate diagnostics exactly occured in the context of code action, so we don't need access global diagnostics to filter them out.

Closes #798

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks, the test case prove its effectiveness so LGTM

@berberman berberman added the merge me Label to trigger pull request merge label Feb 9, 2021
@mergify mergify bot merged commit 691d821 into haskell:master Feb 9, 2021
@berberman berberman deleted the fix-duplicate-pragma branch February 10, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record quick fixes based on fields should be deduped
2 participants