[benchmark] check digests for input files only #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting some weird crashes without this change: ``` Error when running Shake build system: at want, called at bench/hist/Main.hs:87:16 in main:Main * Depends on: bench_example_HLS at need, called at src/Development/Benchmark/Rules.hs:154:37 in shake-bench-0.1.0.0-inplace:Development.Benchmark.Rules * Depends on: bench-results/bench_example_HLS/HEAD/edit.heap.svg * Raised the exception: bench-results/bench_example_HLS/HEAD/edit.heap.svg: openFile: resource busy (file is locked) Benchmark benchHist: ERROR cabal: Benchmarks failed for bench:benchHist from ghcide-0.7.2.0. ```
wz1000
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1306 the benchmark suite can occasionally fail with errors like below. I don't know what causes this. One theory is that it's caused by Shake trying to compute the output file digest. To eliminate potential variables and since we don't need output digests, let's disable them.
After doing this, I've run the benchmark suite several times without seeing any more errors
Fixes #1306 (hopefully)