Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splice Plugin: preparatory version bump for the next (not 0.9.0) HLS release #1312

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

konn
Copy link
Collaborator

@konn konn commented Feb 5, 2021

NOTE: This PR is NOT for releasing 0.9.0 to Hackage; it is preparatory PR to make sure we make another release of the Splice Plugin on Hackage when the next (not 0.9.0) release of HLS has been made; no immediate Hackage release of the bumped version of Splice Plugin is planned.

This PR further bumps the version of hls-splice-plugin to 0.4.0.0 and also changes author and maintainer fields to https://github.com/haskell/haskell-language-server/contributors, rather than my names and address alone.
Note that code of hls-splice-pluigin-0.3.0.0 is inconsistent with the current master branch - it uses locally defined rangeToRealSrcSpan function, which collides with (not yet released) the most recent ghcide's API.

This PR is to make sure the further release of hls-splice-plugin to be made when the next (not 0.9.0) release of HLS is uploaded to Hackage.

@konn konn requested a review from jneira February 5, 2021 12:37
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM here too, thanks!

@konn konn added the merge me Label to trigger pull request merge label Feb 5, 2021
@mergify mergify bot merged commit ab79a4a into master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants