Trigger extending import only when the item is not in scope #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konn
reviewed
Feb 5, 2021
There was a problem hiding this comment.
Seems plausible to me, but I'm not so familiar with caching and benchmarking things to be honest, I would want to wait @pepeiborra to double-check this PR.
pepeiborra
reviewed
Feb 5, 2021
|
To check the performance impact, wait until the Bench jobs are completed, download the artifacts, and look for |
|
The benchmarks look good, there is no noticeable impact in performance |
Ailrun
reviewed
Feb 5, 2021
Ailrun
reviewed
Feb 5, 2021
pepeiborra
reviewed
Feb 5, 2021
pepeiborra
reviewed
Feb 5, 2021
pepeiborra
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1308
Not sure if this will have significant impact on performance...