Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore code actions order #1273

Merged
merged 3 commits into from
Jan 30, 2021
Merged

Restore code actions order #1273

merged 3 commits into from
Jan 30, 2021

Conversation

pepeiborra
Copy link
Collaborator

An unfortunate side effect of recent changes is that the extend import suggestions ended up at the bottom of the list.

This change puts back all code actions provider together so they can be reordered more easily, and restores the previous order where extend imports would be near the top of the list

An unfortunate side effect of recent changes is that the extend import
suggestions ended up at the bottom of the list
@pepeiborra pepeiborra requested review from berberman and konn January 30, 2021 10:59
Copy link
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Jan 30, 2021
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add some tests about the ordering would be great, to not break it (relative between different kinds of?)

@pepeiborra
Copy link
Collaborator Author

maybe add some tests about the ordering would be great, to not break it (relative between different kinds of?)

Such tests would require adjustment every time a new code action is added, an existing code action is changed, etc. So I'm not keen on adding them, some tests are more trouble than they're worth.

But if anyone else wants to do it, I won't oppose either.

@jneira
Copy link
Member

jneira commented Jan 30, 2021

we could check at least the preferred ones are below the cut limit, but definitely not in this pr
otoh relative tests are more maintainable, cause tests than a is before b could be kept while a and b exist

@mergify mergify bot merged commit b97b469 into master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants