Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin support for Rename providers #123

Merged
merged 3 commits into from
May 23, 2020
Merged

Add plugin support for Rename providers #123

merged 3 commits into from
May 23, 2020

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented May 23, 2020 •
edited
Loading

This is a precursor to a Retrie plugin with a RenameProvider

fendor
fendor approved these changes May 23, 2020
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you!

@fendor fendor requested a review from alanz May 23, 2020 09:54
alanz
alanz requested changes May 23, 2020
View reviewed changes
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good bar my nitpick.

src/Ide/Types.hs Outdated Show resolved Hide resolved
@alanz alanz merged commit 6dc7894 into haskell:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanz alanz alanz requested changes

@fendor fendor fendor approved these changes

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pepeiborra @jneira @alanz @fendor