Stale diagnostics fix #1204
Merged
Stale diagnostics fix #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the rule runs, always use the diagnostics it returns The only case where we reuse saved diagnostics is early cutoff
jneira
added a commit
to jneira/haskell-language-server
that referenced
this pull request
Jan 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jan 30, 2021
* Add initial release checklist * Bump up hls version * Add prs running GenChangelogs.hs to ChangeLog * Add description to changelog * Correct checklist entry * Complete list of pr's after rebasing master * Rephrasing mention to contributors * Add mention to #1204 and correct pr's header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes another diagnostics bug introduced by #1188. Diagnostics are tricky but this was a silly mistake.
When a rule runs, the ide must always send the diagnostics returned by the rule. The only case where saved diagnostics are to be reused is early cutoff.
This is what the description of #1188 stated, I have no idea why then in the implementation I changed the non early-cutoff case.