Complete hls-hlint-plugin package metadata #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
approved these changes
Jan 9, 2021
| maintainer: [email protected] (for now) | ||
| maintainer: [email protected] |
There was a problem hiding this comment.
Shouldn't you be listed as the maintainer too @jneira ?
There was a problem hiding this comment.
We probably need some sort of generic reference to the hls team. Is that possible?
There was a problem hiding this comment.
I would prefer some collective thing too, but i am not against include myself if needed, of course.
I guess we would need a generic email account.
There was a problem hiding this comment.
Maybe just put the github repo there?
ndmitchell
approved these changes
Jan 9, 2021
jneira
force-pushed
the
prepare-hlint-plugin-release
branch
from
b88dcb8 to
1a7205a
Compare
jneira
commented
Jan 9, 2021
| @@ -2,11 +2,11 @@ cabal-version: 2.2 | |||
| name: hls-hlint-plugin | |||
| version: 0.1.0.0 | |||
| synopsis: Hlint integration plugin with Haskell Language Server | |||
| description: Please see README.md | |||
| description: Please see Haskell Language Server Readme (https://github.com/haskell/haskell-language-server#readme) | |||
| license: Apache-2.0 | |||
| license-file: LICENSE | |||
| author: Many,TBD when we release | |||
There was a problem hiding this comment.
I guess we should to change this one for sure 😄
If we got a collective description, we could use it here
jneira
force-pushed
the
prepare-hlint-plugin-release
branch
from
25f0521 to
4fe61fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we should update the
authorfield (and others)//cc @alanz @ndmitchell