Test only last ghc minor version and fix windows cache #1173
Conversation
jneira
commented
Jan 8, 2021
•
jneira
commented
- With this configuration, even including macOS builds, the full test workflow takes 47 minutes (https://github.com/jneira/haskell-language-server/actions/runs/471611988). Now it takes 1h 27m 24s (https://github.com/haskell/haskell-language-server/actions/runs/471363372)
- Testing macOs builds takes only 58 min: https://github.com/jneira/haskell-language-server/actions/runs/471344446 so maybe we could add them
- I've dropped optional restore keys cause the builds were hitting other incompatible cache, so it was rebuilding everything in every run cause the final store was not being saved. 😟
|
In this repo the test workflow takes 46 min: https://github.com/haskell/haskell-language-server/actions/runs/472245636 |
.github/workflows/test.yml
Outdated
| # run the tests without parallelism to avoid running out of memory | ||
| run: cabal test ghcide --test-options="-j1 --rerun-update" || cabal test ghcide --test-options="-j1 --rerun" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test ghcide --test-options="-j1 --rerun" | ||
|
|
||
| - name: Test func-test suite | ||
| shell: bash | ||
| if: ${{ !matrix.ghc-lib && matrix.test }} |
There was a problem hiding this comment.
| if: ${{ !matrix.ghc-lib && matrix.test }} | |
| if: ${{ matrix.test }} |
.github/workflows/test.yml
Outdated
|
|
||
| - name: Test wrapper-test suite | ||
| shell: bash | ||
| if: ${{ !matrix.ghc-lib && matrix.test }} |
There was a problem hiding this comment.
| if: ${{ !matrix.ghc-lib && matrix.test }} | |
| if: ${{ matrix.test }} |
|
It looks like we should update |
|
And could you update the GitHub setting for the required checks (I don't have the permission)? It looks like the removed checks remain required. |
|
It seems the mergify config from master is not replaced by this one, weird... |
The mergify config is not completely updated and is required to remove them to unblock haskell#1173
|
@Ailrun is right, we had to update checks in github settings (in addition to mergify) |
|
I've changed the required checks in github settings to match the established ones with this pr. |
|
Checked. The updated setting looks good to me. Thank you for the CI update! |
The mergify config is not completely updated and is required to remove them to unblock haskell#1173
