-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 0.8.0 (versions) #1153
Prepare 0.8.0 (versions) #1153
Conversation
Thanks. Are you planning to update the ghcide changelog as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Pepe Iborra <[email protected]>
We weren't update the changelog of each subcomponent until now and the changelog contains pr's affecting one o more of them at the same time. But maybe we could start to do it, at least for ghcide. should we keep those pr's in the main changelog and in ghcide one or only in the latter? |
@pepeiborra i've added some entries in the ghcide changelog, keeping the main hls one instact. I've taken the list of your comment in the previous pr, removing the existent ones. |
I must be missing something. In #1149 you said that the ghcide changes should go in the ghcide changelog:
That's why I am asking if you are planning to update the ghcide changelog before releasing it.
I don't have an opinion. Probably a link is enough |
Mmm, i see, my intent was to add the missing info (#952) in the last version included in the ghcide changelog (0.6.0.2). With ... and keep the rest of ghcide related pr's, merged after it inclusion in this repo, in the main hls changelog (as they were already included there at that point). But continuing the ghcide changelog seems sensible to me too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow up of #1149