Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no longer needed git submodule update #1145

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Remove no longer needed git submodule update #1145

merged 4 commits into from
Jan 4, 2021

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Jan 2, 2021

Now that ghcide has been merged into hls repo and there are no submodules to speak of, this command seems redundant.

jneira
jneira approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, thanks for cleaning it out

@jneira jneira added the merge me Label to trigger pull request merge label Jan 4, 2021
@mergify mergify bot merged commit 0db2e28 into haskell:master Jan 4, 2021
@jneira
Copy link
Member

jneira commented Jan 4, 2021

thanks mergify! 😄

pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Jan 9, 2021
@jhrcek @jneira @pepeiborra
Remove no longer needed git submodule update (haskell#1145)
12b4edb 
Co-authored-by: Javier Neira <[email protected]>
@jhrcek jhrcek deleted the cleanup-submodule branch January 19, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhrcek @jneira