Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to issues/PRs in ghcide tests. #1142

Merged
merged 7 commits into from
Jan 5, 2021

Conversation

peterwicksstringfield
Copy link
Contributor

@peterwicksstringfield peterwicksstringfield commented Jan 1, 2021

All ghcide issues have been transferred to HLS.

All PRs open at ghcide archive time were transferred, but closed and merged
ghcide PRs were left behind.

Before this commit we have:

  1. Full links.
  2. Numbers like "#xxx" or "-- xxx", referring to ghcide issues/PRs.

After this commit we have:

  1. Full links.
  2. Numbers like "#xxx" or "-- xxx", referring to HLS issues/PRs.

Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an
issue and PR in the same repository with the same number.

Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an
"hls#xxx" which are totally unrelated. One could even be an issue while the
other is a pull request.

Relevant mappings:
ghcide#7 |-> hls#1129
ghcide#71 |-> hls#1102
ghcide#123 |-> hls#713
ghcide#137 |-> hls#1073
ghcide#246 |-> hls#1030
ghcide#247 |-> hls#1029
ghcide#248 |-> hls#1028
ghcide#249 |-> hls#717
ghcide#250 |-> hls#1027
ghcide#273 |-> hls#1017
ghcide#274 |-> hls#1016
ghcide#283 |-> hls#1012
ghcide#310 |-> hls#767
ghcide#315 |-> hls#1002
ghcide#614 |-> hls#891
ghcide#847 |-> hls#831

Closes #718

All ghcide issues have been transferred to HLS.

All PRs open at ghcide archive time were transferred, but closed and merged
ghcide PRs were left behind.

Before this commit we have:
1. Full links.
2. Numbers like "#xxx" or "-- xxx", referring to ghcide issues/PRs.

After this commit we have:
1. Full links.
2. Numbers like "#xxx" or "-- xxx", referring to HLS issues/PRs.

Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an
issue and PR in the same repository with the same number.

Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an
"hls#xxx" which are totally unrelated. One could even be an issue while the
other is a pull request.

Relevant mappings:
ghcide#7   |-> hls#1129
ghcide#71  |-> hls#1102
ghcide#123 |-> hls#713
ghcide#137 |-> hls#1073
ghcide#246 |-> hls#1030
ghcide#247 |-> hls#1029
ghcide#248 |-> hls#1028
ghcide#249 |-> hls#717
ghcide#250 |-> hls#1027
ghcide#273 |-> hls#1017
ghcide#274 |-> hls#1016
ghcide#283 |-> hls#1012
ghcide#310 |-> hls#767
ghcide#315 |-> hls#1002
ghcide#614 |-> hls#891
ghcide#847 |-> hls#831
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, thanks a lot

@jneira jneira added the merge me Label to trigger pull request merge label Jan 4, 2021
@mergify mergify bot merged commit 24ec53a into haskell:master Jan 5, 2021
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Jan 9, 2021
All ghcide issues have been transferred to HLS.

All PRs open at ghcide archive time were transferred, but closed and merged
ghcide PRs were left behind.

Before this commit we have:
1. Full links.
2. Numbers like "#xxx" or "-- xxx", referring to ghcide issues/PRs.

After this commit we have:
1. Full links.
2. Numbers like "#xxx" or "-- xxx", referring to HLS issues/PRs.

Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an
issue and PR in the same repository with the same number.

Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an
"hls#xxx" which are totally unrelated. One could even be an issue while the
other is a pull request.

Relevant mappings:
ghcide#7   |-> hls#1129
ghcide#71  |-> hls#1102
ghcide#123 |-> hls#713
ghcide#137 |-> hls#1073
ghcide#246 |-> hls#1030
ghcide#247 |-> hls#1029
ghcide#248 |-> hls#1028
ghcide#249 |-> hls#717
ghcide#250 |-> hls#1027
ghcide#273 |-> hls#1017
ghcide#274 |-> hls#1016
ghcide#283 |-> hls#1012
ghcide#310 |-> hls#767
ghcide#315 |-> hls#1002
ghcide#614 |-> hls#891
ghcide#847 |-> hls#831

Co-authored-by: Pepe Iborra <[email protected]>
Co-authored-by: Javier Neira <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@peterwicksstringfield peterwicksstringfield deleted the update_issue_links branch January 10, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links to issues in ghcide tests
3 participants