-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to issues/PRs in ghcide tests. #1142
Merged
mergify
merged 7 commits into
haskell:master
from
peterwicksstringfield:update_issue_links
Jan 5, 2021
Merged
Update links to issues/PRs in ghcide tests. #1142
mergify
merged 7 commits into
haskell:master
from
peterwicksstringfield:update_issue_links
Jan 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All ghcide issues have been transferred to HLS. All PRs open at ghcide archive time were transferred, but closed and merged ghcide PRs were left behind. Before this commit we have: 1. Full links. 2. Numbers like "#xxx" or "-- xxx", referring to ghcide issues/PRs. After this commit we have: 1. Full links. 2. Numbers like "#xxx" or "-- xxx", referring to HLS issues/PRs. Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an issue and PR in the same repository with the same number. Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an "hls#xxx" which are totally unrelated. One could even be an issue while the other is a pull request. Relevant mappings: ghcide#7 |-> hls#1129 ghcide#71 |-> hls#1102 ghcide#123 |-> hls#713 ghcide#137 |-> hls#1073 ghcide#246 |-> hls#1030 ghcide#247 |-> hls#1029 ghcide#248 |-> hls#1028 ghcide#249 |-> hls#717 ghcide#250 |-> hls#1027 ghcide#273 |-> hls#1017 ghcide#274 |-> hls#1016 ghcide#283 |-> hls#1012 ghcide#310 |-> hls#767 ghcide#315 |-> hls#1002 ghcide#614 |-> hls#891 ghcide#847 |-> hls#831
pepeiborra
approved these changes
Jan 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
jneira
approved these changes
Jan 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, thanks a lot
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Jan 9, 2021
All ghcide issues have been transferred to HLS. All PRs open at ghcide archive time were transferred, but closed and merged ghcide PRs were left behind. Before this commit we have: 1. Full links. 2. Numbers like "#xxx" or "-- xxx", referring to ghcide issues/PRs. After this commit we have: 1. Full links. 2. Numbers like "#xxx" or "-- xxx", referring to HLS issues/PRs. Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an issue and PR in the same repository with the same number. Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an "hls#xxx" which are totally unrelated. One could even be an issue while the other is a pull request. Relevant mappings: ghcide#7 |-> hls#1129 ghcide#71 |-> hls#1102 ghcide#123 |-> hls#713 ghcide#137 |-> hls#1073 ghcide#246 |-> hls#1030 ghcide#247 |-> hls#1029 ghcide#248 |-> hls#1028 ghcide#249 |-> hls#717 ghcide#250 |-> hls#1027 ghcide#273 |-> hls#1017 ghcide#274 |-> hls#1016 ghcide#283 |-> hls#1012 ghcide#310 |-> hls#767 ghcide#315 |-> hls#1002 ghcide#614 |-> hls#891 ghcide#847 |-> hls#831 Co-authored-by: Pepe Iborra <[email protected]> Co-authored-by: Javier Neira <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All ghcide issues have been transferred to HLS.
All PRs open at ghcide archive time were transferred, but closed and merged
ghcide PRs were left behind.
Before this commit we have:
After this commit we have:
Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an
issue and PR in the same repository with the same number.
Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an
"hls#xxx" which are totally unrelated. One could even be an issue while the
other is a pull request.
Relevant mappings:
ghcide#7 |-> hls#1129
ghcide#71 |-> hls#1102
ghcide#123 |-> hls#713
ghcide#137 |-> hls#1073
ghcide#246 |-> hls#1030
ghcide#247 |-> hls#1029
ghcide#248 |-> hls#1028
ghcide#249 |-> hls#717
ghcide#250 |-> hls#1027
ghcide#273 |-> hls#1017
ghcide#274 |-> hls#1016
ghcide#283 |-> hls#1012
ghcide#310 |-> hls#767
ghcide#315 |-> hls#1002
ghcide#614 |-> hls#891
ghcide#847 |-> hls#831
Closes #718