Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cabal-helper-1.1, add stack-8.10.1.yaml and unify cabal.project's #108

Merged
merged 12 commits into from
May 14, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented May 13, 2020

  • For using cabal-helper-1.1 in windows had been necessary pump up Cabal version to 3.0.2.0 in stack.yaml's
  • There is a unique cabal.project that works for ghc-8.10.1 and a new stack-8.10.1.yaml both without allow-newer
    • Using git dependencies for branches that add support for ghc-8.10.1 in floskell and cabal-plan
  • brittany needs more work to be upgraded, cabal is already excluding it auto from the build plan setting -agpl
  • i've set agpl to False temporary in stack (with a comment about)
  • I had to restrict opentelemery to 0.3 in cabal.project cause the more recent version 0.4 is not compatible with our code

cabal.project Outdated
tag: 78f888f46dae96922d855af1e6a00ea6bb856987

-- TODO adapt code to last opentelemetry-0.4.0
constraints: opentelemetry == 0.3.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in mpickering/ghcide on the hls branch. Maybe we can update ghcide first?

Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this,when you resolve the timing issues for the upstream repo

@jneira jneira force-pushed the cabal-helper-1.1 branch from 1264e54 to 6f8820d Compare May 14, 2020 08:38
@jneira
Copy link
Member Author

jneira commented May 14, 2020

  • I've updated lts's to use the last ones for ghc-8.6.5 (this one will not change anymore) and ghc-8.8.3

@jneira
Copy link
Member Author

jneira commented May 14, 2020

Failing ci builds are in the test step so it seems the build itself works.

@jneira jneira merged commit 0a2be76 into haskell:master May 14, 2020
@jneira jneira deleted the cabal-helper-1.1 branch May 14, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants