-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged plugins pull in disabled deps when building with Setup.hs
#4100
Labels
status: needs info
Not actionable, because there's missing information
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Comments
hololeap
added
status: needs triage
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
labels
Feb 28, 2024
I am pretty sure the |
You might need to pass a target? |
michaelpj
added
the
status: needs info
Not actionable, because there's missing information
label
Mar 3, 2024
fendor
pushed a commit
that referenced
this issue
Apr 6, 2024
* Mark plugins as not buildable if the flag is disabled This ensures that cabal does not consider them at all, and won't try to solve for their dependencies. So if we turn off the fourmolu plugin, cabal really won't consider fourmolu at all. This gets us some of the benefits of #4156 with much less work. Fixes #4100. * Stick to no space after flag for consistency
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: needs info
Not actionable, because there's missing information
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
I'm taking a look at packaging
haskell-language-server-2.7.0.0
for Gentoo Linux. Currently, I have2.6.0.0
and most plugins installed to my system, although I do not have thehls-fourmolu-plugin
orfourmolu
packages installed. Just experimenting with theSetup.hs
interface, I notice that thefourmolu
dependency is being pulled in even when thefourmolu
flag is disabled:cd haskell-language-server-2.7.0.0/ runhaskell Setup.hs configure --flag=-fourmolu
As you can see, it is still looking for
fourmolu
:The changes made in #3976 seem to be selectively choosing which sub-libraries to build using
build-depends
:haskell-language-server/haskell-language-server.cabal
Lines 1298 to 1301 in 41de40e
It seems to me that
Setup.hs
does not seem to have the functionality to handle this, and instead tries to build all sub-libraries mentioned in the.cabal
file, regardless of what flags are toggled.This experiment was done using
ghc-9.2.8
andCabal-3.6.3.0
.The text was updated successfully, but these errors were encountered: