-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate lens only comments the first line of multiline output #2907
Labels
component: hls-eval-plugin
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Comments
konsumlamm
added
status: needs triage
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
labels
May 14, 2022
xsebek
added a commit
to xsebek/haskell-language-server
that referenced
this issue
May 16, 2022
- add test for multiline show instance See haskell#2907
xsebek
added a commit
to xsebek/haskell-language-server
that referenced
this issue
May 16, 2022
xsebek
added a commit
to xsebek/haskell-language-server
that referenced
this issue
May 16, 2022
Hi @konsumlamm and thanks for the bug report. Indeed we were not prefixing the multi-line show results. 😅 Luckily the fix is a one-liner data Multiline = M {l1 :: String, l2 :: String} deriving Read
instance Show Multiline where
show m = "M {\n l1=" <> show (l1 m) <> ",\n l2=" <> show (l2 m) <> "\n}"
-- >>> M "first line" "second line"
-- M {
-- l1="first line",
-- l2="second line"
-- } |
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this issue
May 21, 2022
* Test multiline eval results - add test for multiline show instance See haskell#2907 * Fix multiline eval padding See haskell#2907
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this issue
Aug 26, 2022
* Test multiline eval results - add test for multiline show instance See haskell#2907 * Fix multiline eval padding See haskell#2907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: hls-eval-plugin
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Steps to reproduce
Code:
Click
Evaluate...
:Expected behaviour
Actual behaviour
Versions
GHC: 9.2.2, 9.0.2, 8.10.7
HLS: 1.7.0.0
The text was updated successfully, but these errors were encountered: