Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: test tries to discover in dist-newstyle #251

Closed
GuillaumeDesforges opened this issue Jul 29, 2020 · 5 comments
Closed

Bug: test tries to discover in dist-newstyle #251

GuillaumeDesforges opened this issue Jul 29, 2020 · 5 comments
Labels
CI Continuous integration status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@GuillaumeDesforges
Copy link

From NixOS/nixpkgs#93768

Test suite wrapper-test: RUNNING...
haskell-language-server-wrapper
  --project-ghc-version
    stack with ghc 8.10.1: FAIL
      Exception: dist-newstyle: getDirectoryContents:openDirStream: does not exist (No such file or directory)
    stack with ghc 8.8.3:  FAIL
      Exception: dist-newstyle: getDirectoryContents:openDirStream: does not exist (No such file or directory)
    cabal with global ghc: FAIL
      Exception: dist-newstyle: getDirectoryContents:openDirStream: does not exist (No such file or directory)

3 out of 3 tests failed (0.07s)
Test suite wrapper-test: FAIL
Test suite logged to:
dist/test/haskell-language-server-0.2.2.0-wrapper-test.log

NixOS/nixpkgs#93768 (comment)

I had a chat with lukelau in the hls freenode room. The issue seems to be simple and generic. The test needs the binary in the PATH and they wrote a hack accessing dist-newstyle to discover the binaries.

cc @maralorn
@lukel97
Copy link
Collaborator

lukel97 commented Jul 29, 2020

Can you check that this was fixed in 9d3d0e6

@Ailrun Ailrun added CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: testing labels Jul 29, 2020
@GuillaumeDesforges GuillaumeDesforges mentioned this issue Jul 29, 2020
Merged
10 tasks
@maralorn
Copy link
Contributor

@bubba I will check when I am back at the keyboard. Will probably take a week.

@jneira
Copy link
Member

jneira commented Nov 17, 2020

@GuillaumeDesforges @maralorn could you confirm if this was fixed by the commit referenced above?

@jneira jneira added the status: needs info Not actionable, because there's missing information label Nov 17, 2020
@maralorn
Copy link
Contributor

Sorry for letting this slide. This seems to be fixed.

Of course we have tons of other tests failing and I have trouble fixing all of them.

@jneira
Copy link
Member

jneira commented Nov 19, 2020

Ok, i am gonna close this one then. Feel free to open new ones for failing tests

@jneira jneira closed this as completed Nov 19, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
@jacg @cocreature
Annotate tests with issue numbers (#251)
26ddbbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jneira @maralorn @GuillaumeDesforges @lukel97 @Ailrun