Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing constructors for operators doesn't work properly #1211

Closed
googleson78 opened this issue Jan 15, 2021 · 0 comments · Fixed by #1212
Closed

Importing constructors for operators doesn't work properly #1211

googleson78 opened this issue Jan 15, 2021 · 0 comments · Fixed by #1212
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@googleson78
Copy link
Contributor

googleson78 commented Jan 15, 2021

Environment (current master)

blademaster :: /tmp » ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.8.4
blademaster :: /tmp » haskell-language-server-8.8.4 --version
haskell-language-server version: 0.8.0.0 (GHC: 8.8.4) (PATH: /home/googleson78/.local/bin/haskell-language-server-8.8.4) (GIT hash: 5578b8f423036810e76846b6a9ca89b6aa107a28)

File contents before action

import Data.Type.Equality ((:~:))

x :: (:~:) [] []
x = Refl

File contents after action

import Data.Type.Equality ((:~:(Refl)))

x :: (:~:) [] []
x = Refl

Expected/proper file contents

import Data.Type.Equality ((:~:)(Refl))

x :: (:~:) [] []
x = Refl

(note the closing paren for :~: is directly next to it, before the (Refl))

@googleson78 googleson78 changed the title Importing constructors for operators doesn't work Importing constructors for operators doesn't work properly Jan 15, 2021
@jneira jneira added component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Jan 15, 2021
mrBliss added a commit to mrBliss/haskell-language-server that referenced this issue Jan 15, 2021
Fixes haskell#1211.

When extending the import of a type operator with one of its constructors, don't
forget to put parentheses around the type operator.
mrBliss added a commit to mrBliss/haskell-language-server that referenced this issue Jan 15, 2021
Fixes haskell#1211.

When extending the import of a type operator with one of its constructors, don't
forget to put parentheses around the type operator.
@mergify mergify bot closed this as completed in #1212 Jan 15, 2021
mergify bot pushed a commit that referenced this issue Jan 15, 2021
Fixes #1211.

When extending the import of a type operator with one of its constructors, don't
forget to put parentheses around the type operator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants