Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion for negative language unextensions, i.e. NoDuplicateRecordFields #1187

Closed
expipiplus1 opened this issue Jan 10, 2021 · 1 comment · Fixed by #1238
Closed

Completion for negative language unextensions, i.e. NoDuplicateRecordFields #1187

expipiplus1 opened this issue Jan 10, 2021 · 1 comment · Fixed by #1238
Labels
component: ghcide type: enhancement New feature or request

Comments

@expipiplus1
Copy link
Contributor

HLS seems to prompt me to complete DuplicateRecordFi but not NoDuplicateRecordFi. Would be nice to have these prompted too. (of course NoMonomorphismRestriction is already supported :)
mrBliss added a commit to mrBliss/haskell-language-server that referenced this issue Jan 20, 2021
@mrBliss
Complete the No- variants of language extensions
f34b8a7 
Fixes haskell#1187.

Separate the list of pragmas used for completion from the list of pragmas used
to suggest enabling a language extension to fix an error. The former now include
the `No-` variants of the language extensions, e.g., `NoDuplicateRecordFields`.
@mrBliss mrBliss mentioned this issue Jan 20, 2021
Merged
mrBliss added a commit to mrBliss/haskell-language-server that referenced this issue Jan 20, 2021
@mrBliss
Complete the No- variants of language extensions
8f58652 
Fixes haskell#1187.

Separate the list of pragmas used for completion from the list of pragmas used
to suggest enabling a language extension to fix an error. The former now include
the `No-` variants of the language extensions, e.g., `NoDuplicateRecordFields`.
@mergify mergify bot closed this as completed in #1238 Jan 20, 2021
mergify bot pushed a commit that referenced this issue Jan 20, 2021
@mrBliss
Complete the No- variants of language extensions (#1238)
50854ca 
Fixes #1187.

Separate the list of pragmas used for completion from the list of pragmas used
to suggest enabling a language extension to fix an error. The former now include
the `No-` variants of the language extensions, e.g., `NoDuplicateRecordFields`.
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Jan 21, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@jneira @expipiplus1