Add reproduction for #2290

haskell · Nov 5, 2021 · ebd9445 · ebd9445
1 parent 92f776d
commit ebd9445
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/plugins/hls-hlint-plugin/test/Main.hs b/plugins/hls-hlint-plugin/test/Main.hs
@@ -139,6 +139,9 @@ suggestionsTests =
     , testCase "apply-refact preserve regular comments" $ runHlintSession "" $ do
         testRefactor "Comments.hs" "Redundant bracket" expectedComments
 
+    , testCase "[#2290] apply all hints works with a trailing comment" $ runHlintSession "" $ do
+        testRefactor "TwoHintsAndComment.hs" "Apply all hints" expectedComments2
+
     , testCase "applyAll is shown only when there is at least one diagnostic in range" $  runHlintSession "" $ do
         doc <- openDoc "TwoHints.hs" "haskell"
         _ <- waitForDiagnosticsFromSource doc "hlint"
@@ -212,6 +215,9 @@ suggestionsTests =
                              , "f = {- inline comment -}{- inline comment inside refactored code -} 1 -- ending comment", ""
                              , "-- final comment"
                              ]
+        expectedComments2 =  [ "module TwoHintsAndComment where"
+                             , "biggest items = foldr1 max -- the line above will show two hlint hints, \"eta reduce\" and \"use maximum\""
+                             ]
         expectedTypeApp =    [ "module TypeApplication where", ""
                              , "a = id @Int 1"
                              ]

diff --git a/plugins/hls-hlint-plugin/test/testdata/TwoHintsAndComment.hs b/plugins/hls-hlint-plugin/test/testdata/TwoHintsAndComment.hs
@@ -0,0 +1,3 @@
+module TwoHintsAndComments where
+
+biggest items = foldr1 max items -- the line above will show two hlint hints, "eta reduce" and "use maximum"
diff --git a/plugins/hls-hlint-plugin/test/testdata/hie.yaml b/plugins/hls-hlint-plugin/test/testdata/hie.yaml
@@ -13,3 +13,4 @@ cradle:
       - "TwoHints"
       - "PatternKeyword"
       - "StrictData"
+      - "TwoHintsAndComment"
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		module TwoHintsAndComments where

		biggest items = foldr1 max items -- the line above will show two hlint hints, "eta reduce" and "use maximum"