Skip to content

Commit

Permalink
hls-haddock-comments does not support ghc-exactprint >= 1.0 (#2878)
Browse files Browse the repository at this point in the history
* hls-haddock-comments does not support ghc-exactprint >= 1.0

And should be marked as such otherwise `cabal install haskell-language-server` generates an unbuildable plan

* Try to make CI happy

Co-authored-by: Pepe Iborra <[email protected]>
  • Loading branch information
Bodigrim and pepeiborra authored May 1, 2022
1 parent 5a6b079 commit 4b475b0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions cabal-ghc92.project
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ allow-newer:
-- https://github.com/lspitzner/butcher/pull/8
butcher:base,

hls-haddock-comments-plugin:ghc-exactprint,

implicit-hie-cradle:bytestring,
implicit-hie-cradle:time,

Expand Down
2 changes: 1 addition & 1 deletion haskell-language-server.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ common callHierarchy
cpp-options: -DcallHierarchy

common haddockComments
if flag(haddockComments)
if flag(haddockComments) && (impl(ghc < 9.2.1) || flag(ignore-plugins-ghc-bounds))
build-depends: hls-haddock-comments-plugin ^>= 1.0
cpp-options: -DhaddockComments

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ library
, base >=4.12 && <5
, containers
, ghc
, ghc-exactprint
, ghc-exactprint < 1
, ghcide ^>=1.6 || ^>=1.7
, hls-plugin-api ^>=1.3 || ^>=1.4
, lsp-types
Expand Down

0 comments on commit 4b475b0

Please sign in to comment.