Fix multi unit session when some packages have reexported modules. #4654
Annotations
14 warnings
Hlint check run
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Hlint check run:
exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L537
Warning in loadSessionWithOptions in module Development.IDE.Session: Use fromMaybe ▫︎ Found: "maybe [] id" ▫︎ Perhaps: "fromMaybe []"
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L597
Warning in loadSessionWithOptions in module Development.IDE.Session: Use map ▫︎ Found: "zip (map fst $ concatMap toFlagsMap all_targets) (repeat hieYaml)" ▫︎ Perhaps: "map (, hieYaml) (map fst $ concatMap toFlagsMap all_targets)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L660
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef' cradle_files (\\ xs -> (cfp : xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ cradle_files ((:) cfp)"
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L688
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> []" ▫︎ Perhaps: "const []"
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L88
Warning in parseMultiCradleErr in module Development.IDE.Session.Diagnostics: Use drop1 ▫︎ Found: "drop 1" ▫︎ Perhaps: "drop1"
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session/Implicit.hs#L53
Suggestion in inferCradleTree in module Development.IDE.Session.Implicit: Use <&> ▫︎ Found: "cabalExecutable\n >> (cabalConfigDir start_dir <|> cabalFileAndWorkDir)\n >>= pure . simpleCabalCradle" ▫︎ Perhaps: "(cabalExecutable\n >> (cabalConfigDir start_dir <|> cabalFileAndWorkDir))\n Data.Functor.<&> simpleCabalCradle"
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session/Implicit.hs#L57
Suggestion in inferCradleTree in module Development.IDE.Session.Implicit: Use <&> ▫︎ Found: "cabalExecutable >> cabalFileDir start_dir\n >>= pure . simpleCabalCradle" ▫︎ Perhaps: "(cabalExecutable >> cabalFileDir start_dir)\n Data.Functor.<&> simpleCabalCradle"
|
Hlint check run:
ghcide/src/Development/IDE/Core/Compile.hs#L76
Warning in module Development.IDE.Core.Compile: Use fewer imports ▫︎ Found: "import Development.IDE.Core.FileStore ( resetInterfaceStore )\nimport Development.IDE.Core.FileStore ( shareFilePath )\n" ▫︎ Perhaps: "import Development.IDE.Core.FileStore\n ( resetInterfaceStore, shareFilePath )\n"
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|