Fix more code actions in windows #1399

jneira · 2019-09-30T11:53:34Z

Follow up of Fix code renaming in windows #1392
It turns out that there were more places where the code assumed ‘ and ’ as term delimiters
- And it assumed that the symbol to start a list option was • (in windows is *)
It fixes almost all failed tests listed in Error in windows detected by the functional test suite #1391 (all except 11, 12 and 13) 😄
The duplicated function extractTerm could be in common module but i am not sure where would be: maybe Haskell.Ide.Engine.PluginUtils in hie-plugin-api?
An alternative impl for extractTermwould be T.init $ T.tail $ T.dropWhileEnd (/= b) $ T.dropWhile (/= e), do you think that it would be better?

src/Haskell/Ide/Engine/Plugin/Package.hs

jneira added 3 commits September 30, 2019 13:31

Extract extractTerm to extend handling of win delims

e2396f7

Fix extractImportableTerm for windows handling os specific delims

3efbee3

Fix extractModuleName for windows handling os specific delims

38cf06b

jneira requested a review from fendor September 30, 2019 11:53

fendor approved these changes Sep 30, 2019

View reviewed changes

src/Haskell/Ide/Engine/Plugin/Package.hs Outdated Show resolved Hide resolved

jneira mentioned this pull request Sep 30, 2019

Error in windows detected by the functional test suite #1391

Closed

Move extractTerm to HieExtras and reuse it

8cc09e6

lukel97 approved these changes Sep 30, 2019

View reviewed changes

jneira merged commit 9feb2eb into haskell:master Sep 30, 2019

jneira deleted the fix-enc-terms branch October 2, 2019 05:38

Provide feedback