Fix UriCaches being leaked

[lukel97]

This fixes UriCaches from being leaked via GhcModuleCaches. This is the result of 72 hours at ZuriHac between 3 people and a lot of time spent in gdb.

Fixes #412, #806, #665
Blog post coming soon

Co-Authored-By: Matthew Pickering [email protected]
Co-Authored-By: Daniel Gröber [email protected]

[alanz]

This leaves me wondering how we strayed from best practice of making all data structure fields strict, unless there is a good reason not to.

[wz1000]

LGTM. Any concrete before/after measurements?

[lukel97]

@wz1000 Running with an lsp-test test-scenario that makes 10 edits:

Before 🚰

After

[lukel97]

@wz1000 I will tidy up the test executable and make a separate PR for it

[lorenzo]

Should we just add StrictData as default extension to the project?

[alanz]

Should we just add StrictData as default extension to the project?

So long as there is a way to mark fields as lazy, if required.

[alanz]

And it is great to have the ability to profile in the project knowledge base. Well done.

[lorenzo]

So long as there is a way to mark fields as lazy, if required.

Yes it is possible, you can make any field lazy by prepending ~ to it. It has the opposite effect of !

[lorenzo]

@bubba Would you mind profiling again after adding StrictData by default?

[lukel97]

@lorenzo sure! I’ll see if I can convert my test case into a benchmark actually