Build with Cabal-3.8 and GHC 9.4 #1141

andreasabel · 2022-10-25T21:28:26Z

Warning! This PR makes hackage-server compile with Cabal-3.8, but does not add any Cabal-3.8 specific features.

Blocked on:

Cabal-3.8.1.0 depends on too recent process-1.6.14, rendering it unusable with package ghc-9.2.4 and older cabal#8554

andreasabel · 2022-10-26T12:02:30Z

Somehow the use of Cabal-3.8 fails with GHC 9.2 and below, with one factor being the dependencies of doctest-parallel. If in CI i fix ghc to the installed package, no build plan is found:

cabal-3.6.2.0: Could not resolve dependencies:
[__0] trying: hackage-server-0.5.1 (user goal)
[__1] rejecting: hackage-server:!test (constraint from config file, command line flag, or user target requires opposite flag selection)
[__1] trying: hackage-server:*test
[__2] trying: doctest-parallel-0.2.5 (dependency of hackage-server *test)
[__3] trying: ghc-9.2.4/installed-9.2.4 (dependency of doctest-parallel)
[__4] next goal: Cabal (dependency of hackage-server)
[__4] rejecting: Cabal-3.6.3.0/installed-3.6.3.0 (conflict: hackage-server => Cabal^>=3.8.1.0)
[__4] rejecting: Cabal-3.8.1.0 (conflict: ghc => process==1.6.13.2/installed-1.6.13.2, Cabal => process>=1.6.14.0 && <1.7)

I don't understand the last part: Cabal => process>=1.6.14.0 && <1.7. Where does this come from? On https://hackage.haskell.org/package/Cabal, the lower bound is >= 1.2. Ok, when looking closer, at https://hackage.haskell.org/package/Cabal-3.8.1.0/dependencies, then I see this:

if impl(ghc>=8.2)
  process >=1.6.14.0

I wonder what purpose is served by this? https://hackage.haskell.org/package/process-1.6.14.0 was released 2022-02-15, but GHC 8.2 was released much earlier (in 2017). Basically, no installed ghc will be compatible with such a recent version of process.

Reason: haskell/cabal#8554 Cabal-3.8.1.0 does not work with ghc < 9.4 needed by doctest-parallel

….6.14

andreasabel · 2022-10-27T19:53:35Z

@gbaz suggested in haskell/cabal#8554 (comment):

for just making things work for hackage server, we can toss allow-older into the cabal.project file

This works locally (e.g. on my machine). However, haskell-ci which generates our cabal-CI does not take the cabal.project* files into account, it actually deletes them. Also, it does not support allow-newer/older settings to be passed in via the cabal.haskell-ci configuration file. This somehow makes sense, as it tests the packages as if it had been released to hackage. In particular it uses the sdist generated tarball rather than the repo code directly. This was actually a feature I wanted, to detect files forgotten in the hackage-server.cabal file, see:

Auto-generate more complete CI via haskell-ci #1061 (comment)

For now, I get haskell-ci.yml to pass by switching off the tests for ghc < 9.4. This removes the dependency path doctest-parallel -> ghc -> process, so it is ok if Cabal-3.8 wants a too recent process.

I don't have any clue how to fix the nix-shell.yml workflow. @peterbecich, could you have a look?
It seems to use ghc-9.0 and seems to want to build the tests. If you upgrade it to ghc-9.4 it might just work.

andreasabel · 2022-10-28T07:28:46Z

src/Distribution/Server/Features/BuildReports/BuildReport.hs

+#if MIN_VERSION_Cabal(3,7,0)
+import Distribution.Fields.Pretty
+         ( pattern NoComment )
+#endif


Alternatively, instead of #if, we could burn the bridges and drop Cabal-3.6 entirely.

andreasabel · 2022-10-28T07:29:56Z

src/Distribution/Server/Util/CabalRevisions.hs

@@ -39,6 +40,9 @@ import Distribution.Version
 import Distribution.Compiler (CompilerFlavor)
 import Distribution.FieldGrammar (prettyFieldGrammar)
 import Distribution.Fields.Pretty (PrettyField (..), showFields)
+#if MIN_VERSION_Cabal(3,7,0)
+import Distribution.Fields.Pretty (pattern NoComment)
+#endif


I want this file to remain in sync with its copy in hackage-cli, so the CPP would stay here.

andreasabel · 2022-10-28T07:31:44Z

@gbaz : With CI green, maybe you want to review now?

gbaz

Looks great, thanks!

What 3.8 specific features do you think we need to consider supporting, if any?

ulysses4ever · 2022-10-28T17:26:41Z

Multi-lib packages?

andreasabel · 2022-10-28T19:23:29Z

I don't have any clue how to fix the nix-shell.yml workflow. @peterbecich, could you have a look?
It seems to use ghc-9.0 and seems to want to build the tests. If you upgrade it to ghc-9.4 it might just work.

I fixed this by adding allow-older: Cabal:process to the cabal.project file. But anyway, there seems a 22.05 nixos available (I could be mistaken) so we could upgrade from 21.11, maybe.

andreasabel · 2022-10-29T09:28:25Z

I'll merge this now, and open an issue for supporting Cabal-3.8 features.

* delete unused GitHub Action; fix CI badge * Fix #1076: separate validators from UI and doctest them (#1077) * Cachix caching for nix-shell GitHub Action (#1081) * Add uploaded_at field in package api (#1080) * package page: Include virtual-modules in module tree (#1085) * Allow hashable-1.4 and text-2.0 (#1089) * Divide sitemap into parts * Add sitemap link for subdirectories * Fix `non-canonical-return` warnings * Bump CI to GHC 9.2.3 and restrict to master branch * Check authorisation (#1111) * Dynamically add css piece * Fix #1105: change order of markdown parsers to allow pipes in lists * Fix #1128, fix #1130 by adding bounds to Cabal-syntax and haddock-library * Bump CI to 9.2.4 and some deps * Force .txt and .text to have UTF-8 MIME charset (#1133) * Upgrade to haddock-library-1.11.0 (#1126) * attempt to speed up GitHub Action for Nix Shell * work with cabal 3.8 * Updated accepted licenses (#1092) * Add dependabot for github workflows * Bump cachix/cachix-action from 10 to 12 * Bump actions/checkout from 2.4.0 to 3.1.0 * Bump cachix/install-nix-action from 17 to 18 * Build with Cabal-3.8 and GHC 9.4 (#1141) * Haskell CI: bump to Ubuntu-22.04, GHC 9.2.5 and 9.4.4 * Allow mtl-2.3 and transformers-0.6 (#1150) * Disable test (#1124) * allow disable tests on client side * add deprecated version warning (#1123) * List maintainers on package page (#1098) * List maintainers on package page * Vendor snowball package (#1116) * Add searchbox metadata (#1115) * Add captcha for user registration (#1099) * remove filtering 00-index for cabal version < 2.0 hack (#1152) * Add lastVersion in listings (#749) (#1140) * rm icu dep instructions, add libgd * Add test log display (#1100) * Add test log * Reverse Dependencies indexed on PackageName (#1082) * Rebased Reverse Dependencies * Add "Quick Jump" to candidate package page (#1122) * Solves #1029 - Adds paging to recent packages and recent revisions (#1055) * support for `prefers-color-scheme` (#1008) * 2x brightness for captions and links in dark color scheme * table dark color scheme * prefers-color-scheme for links, footer, and table-of-contents * paginator css for `prefers-color-scheme` * Maintainer notifications * cleanup partial functions for revdeps, elim use of MonadThrow, MonadCatch * fix tests enablement link Co-authored-by: Peter Becich <[email protected]> Co-authored-by: Andreas Abel <[email protected]> Co-authored-by: Hécate Moonlight <[email protected]> Co-authored-by: Matthew Pickering <[email protected]> Co-authored-by: ˌbodʲɪˈɡrʲim <[email protected]> Co-authored-by: Alias Qli <[email protected]> Co-authored-by: Ondřej Kubánek <[email protected]> Co-authored-by: Gautier DI FOLCO <[email protected]> Co-authored-by: Janus Troelsen <[email protected]> Co-authored-by: Levi Butcher <[email protected]>

Build with Cabal-3.8 and GHC 9.4

22613d5

andreasabel added the re: Cabal-3.8 Concerning building with the Cabal-3.8 library label Oct 25, 2022

CI: relax constraint on installed packages

32505ed

andreasabel mentioned this pull request Oct 25, 2022

Depending on doctest-parallel fails with attempt of reinstalling ghc martijnbastiaan/doctest-parallel#51

Closed

Drop GHC 8.8 and fix ghc to installed version on CI

2caabc9

This was referenced Oct 26, 2022

process >= 1.6.14 requires ghc-9.2.4 to be built again, which causes error haskell/cabal#8489

Closed

Cabal-3.8.1.0 depends on too recent process-1.6.14, rendering it unusable with package ghc-9.2.4 and older haskell/cabal#8554

Closed

andreasabel added 2 commits October 26, 2022 15:55

Haskell CI: switch off testing for GHC 9.2 and below

8b7f047

Reason: haskell/cabal#8554 Cabal-3.8.1.0 does not work with ghc < 9.4 needed by doctest-parallel

Haskell CI: relax process, so Cabal-3.8.1.0 can get its beloved 1…

ea74198

….6.14

allow-older: Cabal:process to work around haskell/cabal#8554

70d942d

andreasabel commented Oct 28, 2022

View reviewed changes

andreasabel requested a review from gbaz October 28, 2022 07:31

gbaz approved these changes Oct 28, 2022

View reviewed changes

Haskell CI: bring back GHC 8.8.4

c1002d4

andreasabel merged commit 0632086 into master Oct 29, 2022

andreasabel deleted the Cabal-3.8 branch October 29, 2022 09:37

andreasabel mentioned this pull request Oct 29, 2022

Support Cabal-3.8 & 3.10 innovations #1146

Closed

gbaz mentioned this pull request Jan 6, 2023

master -> central server jan 2023 #1158

Merged

andreasabel mentioned this pull request Apr 12, 2023

Build hackage-server with latest Haskell ecosystem #1041

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build with Cabal-3.8 and GHC 9.4 #1141

Build with Cabal-3.8 and GHC 9.4 #1141

andreasabel commented Oct 25, 2022 •

edited

Loading

andreasabel commented Oct 26, 2022

andreasabel commented Oct 27, 2022

andreasabel Oct 28, 2022

andreasabel Oct 28, 2022

andreasabel commented Oct 28, 2022

gbaz left a comment

ulysses4ever commented Oct 28, 2022

andreasabel commented Oct 28, 2022

andreasabel commented Oct 29, 2022

Build with Cabal-3.8 and GHC 9.4 #1141

Build with Cabal-3.8 and GHC 9.4 #1141

Conversation

andreasabel commented Oct 25, 2022 • edited Loading

andreasabel commented Oct 26, 2022

andreasabel commented Oct 27, 2022

andreasabel Oct 28, 2022

Choose a reason for hiding this comment

andreasabel Oct 28, 2022

Choose a reason for hiding this comment

andreasabel commented Oct 28, 2022

gbaz left a comment

Choose a reason for hiding this comment

ulysses4ever commented Oct 28, 2022

andreasabel commented Oct 28, 2022

andreasabel commented Oct 29, 2022

andreasabel commented Oct 25, 2022 •

edited

Loading