Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some hlint warnings - part 2 #1057

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Conversation

jhrcek
Copy link
Contributor

@jhrcek jhrcek commented Apr 13, 2022

Second batch of hopefully non-controversial hlint fixes (as discussed in #1056 (comment)).

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would abstain from the data -> newtype conversions. (see my comment)
Everything else has my 100% approval!

@jhrcek jhrcek requested a review from andreasabel April 13, 2022 13:53
@jhrcek
Copy link
Contributor Author

jhrcek commented Apr 15, 2022

@andreasabel friendly ping 😸

@gbaz gbaz merged commit af11ace into haskell:master Apr 15, 2022
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update! Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants