Simplify getting all package names and use itemCache
in Browse
#1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit optimizes getting the list of all package names, by removing the highly inefficient
toPackageNames
and instead creatingallPackageNames
which uses the keys of a map instead of the values thattoPackageNames
was iterating over. This commit also introduces use of this new function in places where this is all we need.The second commit optimizes the browse listing (i.e. not search), which was doing
n
map lookups usingmakeItemList
, wheren
is the total amount of packages. This is now avoided by simply fetching pre-madePackageItem
s usinggetAllLists
. The speedup may not be large since the construction of thesePackageItem
s usingmakeItemList
was already used in the search feature, and this branch wasn't reported to be slow.Tested on my local Hackage instance, but not benchmarked properly yet.