Generate a more complete CI using haskell-ci #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Feb 13, 2022
| - name: apt | ||
| run: | | ||
| apt-get update | ||
| + apt-get install -y --no-install-recommends libbrotli-dev |
There was a problem hiding this comment.
% haskell-ci --help|grep apt
--ghcup-version VERSION | --apt PKG |
--apt PKG Additional apt packages to install
This was referenced Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes an alternative CI that is built with
haskell-ciplus some postprocessing viapatch.The patching works around the following limitations of
haskell-ci github:libbrotli-dev)--haddock). A haddock step is currently only added forlibrarypackages.The hope with a
haskell-cigenerated CI would be that it is easier upgradable (by upgradinghaskell-ci, rather than tinkering with the workflow). It might also be more robust.But I am not sure if this PR is an overall improvement of the status quo; there are also drawbacks, like extra indirection.
Maybe this PR shouldn't be merged right now, but might be come in handy in the future...
(If merged, then please squash.)